Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: update uvwasi to 0.0.20 and fixup tests #51355

Closed
wants to merge 1 commit into from
Closed

deps: update uvwasi to 0.0.20 and fixup tests #51355

wants to merge 1 commit into from

Conversation

mhdawson
Copy link
Member

@mhdawson mhdawson commented Jan 3, 2024

@mhdawson
deps: update uvwasi to 0.0.20 and fixup tests
809db7f 
- update uvwasi to 0.0.20
- adjust tests to reflect udpated behaviour from
  nodejs/uvwasi#224 included
  in uvwasi 0.0.20

Signed-off-by: Michael Dawson <midawson@redhat.com>
@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/wasi

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. wasi Issues and PRs related to the WebAssembly System Interface. labels Jan 3, 2024
@mhdawson
Copy link
Member Author

mhdawson commented Jan 3, 2024

Replaces - #51275 as update to new version required adjustment of Node.js tests.

@mhdawson
Copy link
Member Author

mhdawson commented Jan 4, 2024

Failure on macos look unrelated.

@mhdawson mhdawson added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2024
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 4, 2024
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56673/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/56691/

lpinca
lpinca approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@lpinca lpinca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

mhdawson added a commit that referenced this pull request Jan 8, 2024
@mhdawson
deps: update uvwasi to 0.0.20 and fixup tests
3badecd 
- update uvwasi to 0.0.20
- adjust tests to reflect udpated behaviour from
  nodejs/uvwasi#224 included
  in uvwasi 0.0.20

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #51355
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mhdawson
Copy link
Member Author

mhdawson commented Jan 8, 2024

Landed in 3badecd

@mhdawson mhdawson closed this Jan 8, 2024
marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Jan 12, 2024
@mhdawson @marco-ippolito
deps: update uvwasi to 0.0.20 and fixup tests
0cd43ea 
- update uvwasi to 0.0.20
- adjust tests to reflect udpated behaviour from
  nodejs/uvwasi#224 included
  in uvwasi 0.0.20

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#51355
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@mhdawson mhdawson mentioned this pull request Jan 18, 2024
Open
Medhansh404 pushed a commit to Medhansh404/node that referenced this pull request Jan 19, 2024
@mhdawson @Medhansh404
deps: update uvwasi to 0.0.20 and fixup tests
e48d228 
- update uvwasi to 0.0.20
- adjust tests to reflect udpated behaviour from
  nodejs/uvwasi#224 included
  in uvwasi 0.0.20

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: nodejs#51355
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos pushed a commit that referenced this pull request Feb 15, 2024
@mhdawson @targos
deps: update uvwasi to 0.0.20 and fixup tests
17cb4af 
- update uvwasi to 0.0.20
- adjust tests to reflect udpated behaviour from
  nodejs/uvwasi#224 included
  in uvwasi 0.0.20

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #51355
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@marco-ippolito marco-ippolito mentioned this pull request Mar 1, 2024
Merged
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@mhdawson @richardlau
deps: update uvwasi to 0.0.20 and fixup tests
ef88d89 
- update uvwasi to 0.0.20
- adjust tests to reflect udpated behaviour from
  nodejs/uvwasi#224 included
  in uvwasi 0.0.20

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #51355
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 25, 2024
@mhdawson @richardlau
deps: update uvwasi to 0.0.20 and fixup tests
4c8fa3e 
- update uvwasi to 0.0.20
- adjust tests to reflect udpated behaviour from
  nodejs/uvwasi#224 included
  in uvwasi 0.0.20

Signed-off-by: Michael Dawson <midawson@redhat.com>
PR-URL: #51355
Reviewed-By: Guy Bedford <guybedford@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@richardlau richardlau mentioned this pull request Mar 25, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@guybedford guybedford guybedford approved these changes

Assignees
No one assigned
Labels
needs-ci PRs that need a full CI run. wasi Issues and PRs related to the WebAssembly System Interface.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mhdawson @nodejs-github-bot @guybedford @lpinca